6502.org Forum  Projects  Code  Documents  Tools  Forum
It is currently Fri Nov 22, 2024 3:53 pm

All times are UTC




Post new topic Reply to topic  [ 413 posts ]  Go to page Previous  1 ... 6, 7, 8, 9, 10, 11, 12 ... 28  Next
Author Message
PostPosted: Tue Dec 15, 2020 12:40 pm 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
jdimeglio wrote:
Bug found

Sorry guys i know Daryl been the man on this but i believe ive found a bug.
See attached example. Basically if i use (using 65C02)

jsr $1000
.ASCIS ESC,"[s"

I should be getting the following bytes $20,$00,$10,$27,$5b,$f3 but instead I get $20,$00,$5b,$f3
So $10,$27 goes walk about. However using .ASCII works fine.

Thanks in advance..


I will look into this - thanks for letting me know!!

Daryl

_________________
Please visit my website -> https://sbc.rictor.org/


Top
 Profile  
Reply with quote  
PostPosted: Tue Dec 15, 2020 8:58 pm 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
I have located the bug with the ASCIS directive and will post a fix by tomorrow.

Daryl

_________________
Please visit my website -> https://sbc.rictor.org/


Top
 Profile  
Reply with quote  
PostPosted: Tue Dec 15, 2020 9:06 pm 
Offline
User avatar

Joined: Thu May 28, 2009 9:46 pm
Posts: 8505
Location: Midwestern USA
jdimeglio wrote:
Bug found

Sorry guys i know Daryl been the man on this but i believe ive found a bug.
See attached example. Basically if i use (using 65C02)

jsr $1000
.ASCIS ESC,"[s"

I should be getting the following bytes $20,$00,$10,$27,$5b,$f3 but instead I get $20,$00,$5b,$f3
So $10,$27 goes walk about. However using .ASCII works fine.

Thanks in advance..

I was able to reproduce your problem. One note: you have ESC defined as $27. ASCII <ESC> is $1B or decimal 27. Is that what you meant?

_________________
x86?  We ain't got no x86.  We don't NEED no stinking x86!


Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 16, 2020 2:27 am 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
Edited - file removed. see below.

The bug was created when I added the .DWORD and .XWORD directives. I misinterpreted how the parsing for the directives worked and obviously didn't test it enough :oops: . It was a single line change in the assembler code.

It's all fixed now. I'm calling this version 1.3.3.1, as it was just a bug fix.

Here is the new package.

Thank you again Jdimeglio for pointing it out.

Daryl

_________________
Please visit my website -> https://sbc.rictor.org/


Last edited by 8BIT on Wed Dec 16, 2020 1:00 pm, edited 1 time in total.

Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 16, 2020 8:36 am 
Offline
User avatar

Joined: Wed Nov 11, 2020 3:33 am
Posts: 22
Location: Sydney
Many thanks awesome - yep fixed.

Except (sorry) another issue. :D
PS: I really appreciate your work - i know this is for love rather than for $$$ :-)

The issue is i'm getting ERROR E022: Phase error--inconsistent label value between passes
I've tracked it down to being the next label in the code after a .ASCIS is declared

See attached example.

Again thanks in advance


Attachments:
bug.asm [279 Bytes]
Downloaded 87 times

_________________
_________________________________________________________________________
Checkout my 2pass assembler/monitor https://github.com/jdimeglio/6502-Monitor
Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 16, 2020 12:49 pm 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
OK, no worries. I'll take another look later tonight.

Thanks!!

Daryl

_________________
Please visit my website -> https://sbc.rictor.org/


Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 16, 2020 1:06 pm 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
Well of course there is a phase error, I fixed the issue, but only for the second pass where code is generated. The first pass still had the old formula. It won't show up until there is label afterwards. This too is now fixed. Here's version 1.3.3.2.

Thanks again for your help with ironing out the bugs!!

Daryl


Attachments:
File comment: revised v1.3.3.2 - fixed ASCIS bugs
6502 v1.3.3.2.zip [621.58 KiB]
Downloaded 64 times

_________________
Please visit my website -> https://sbc.rictor.org/


Last edited by 8BIT on Tue Dec 29, 2020 3:10 am, edited 1 time in total.
Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 16, 2020 2:25 pm 
Offline
User avatar

Joined: Fri Dec 11, 2009 3:50 pm
Posts: 3367
Location: Ontario, Canada
jdimeglio wrote:
PS: I really appreciate your work - i know this is for love rather than for $$$ :-)

I'll echo this, Daryl. And I'm sure I'm not the only one who's been silently (but gratefully) following the topic. What you're doing is a wonderful contribution, a permanent and solidly valuable asset for our community. Three cheers!

(Thanks to those who assist with their testing and reports, too.)

-- Jeff

_________________
In 1988 my 65C02 got six new registers and 44 new full-speed instructions!
https://laughtonelectronics.com/Arcana/ ... mmary.html


Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 16, 2020 2:46 pm 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
Thanks Jeff, and everyone else too!

I have always loved a challenge, and I think I like coding over hardware - although I do like to take things apart too and see how they work ;)

Its fun to say - hey, I wonder if this "thing" can do that? And then go about trying to get it to do it. And when I have, I start to think, is this the best way, or can I do it better? It never stops.

My hat is off to Michal for building the Simulator. He built a solid platform and gratefully shared his work. Without his contribution, I would not have taken up this challenge. I also have to begrudgingly say thanks to Microsoft for making their development tools available at no cost - love them or hate them, we would not have many of the tools we need without their support.

I hope everyone has a very merry and safe Christmas this year - despite all the doom and gloom in the world, there is still plenty to be thankful for. I for one am blessed with a loving and supportive family and great friends here at 6502.org.

Daryl

_________________
Please visit my website -> https://sbc.rictor.org/


Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 16, 2020 3:06 pm 
Offline
User avatar

Joined: Wed Sep 03, 2003 6:53 pm
Posts: 153
Location: Long Island, NY
Dr Jefyll wrote:
jdimeglio wrote:
PS: I really appreciate your work - i know this is for love rather than for $$$ :-)

I'll echo this, Daryl. And I'm sure I'm not the only one who's been silently (but gratefully) following the topic. What you're doing is a wonderful contribution, a permanent and solidly valuable asset for our community. Three cheers!

(Thanks to those who assist with their testing and reports, too.)

-- Jeff

I 1000% (that's percent, not binary :-)) agree with that. Having written complex emulation software before, I can appreciate the effort going into it. Thank you Daryl for continuing to maintain it for the community. I know that I appreciate it very much.

Merry Christmas and happy holidays to all.
Rich

_________________
Rich Cini
Build Master and maintainer of the Altair32 Emulation project
http://cini.classiccmp.org
http://altair32.classiccmp.org


Top
 Profile  
Reply with quote  
PostPosted: Fri Dec 18, 2020 6:42 am 
Offline
User avatar

Joined: Wed Nov 11, 2020 3:33 am
Posts: 22
Location: Sydney
Many thanks Daryl, again really appreciate your time. Now we have a happy Joe down under.

In the Merry Christmas & happy new year people.

:-)





_________________________________________________________________________
Checkout my 2pass assembler/monitor https://github.com/jdimeglio/6502-Monitor

_________________
_________________________________________________________________________
Checkout my 2pass assembler/monitor https://github.com/jdimeglio/6502-Monitor


Top
 Profile  
Reply with quote  
PostPosted: Fri Dec 18, 2020 4:12 pm 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
You're welcome Joe!

Enjoy your Christmas too - even though its summertime for you. Visiting your fine country is still on my bucket list.

Be well!

Daryl

_________________
Please visit my website -> https://sbc.rictor.org/


Top
 Profile  
Reply with quote  
PostPosted: Mon Dec 28, 2020 6:49 am 
Offline
User avatar

Joined: Wed Nov 11, 2020 3:33 am
Posts: 22
Location: Sydney
Happy New boys

umm a couple more bugs :-D Promise im not looking for giving anyone extra work.

#1 bug

Opening the memory dump {ie: pressing alt-2} and there's a line across the screen 10 rows down saying debug with the address of the memory block. My guess there's some quick code for debugging left in the compile :-)

#2 bug

.ASCIS bug is back (kinda of) only its when you have a comma and a label in the line.

.ASCIS "123" works
.ASCIS "1","2" works
.ASCIS ESC,"1" doesn't - it drops some bytes.

Yet with .ASCII perfect on all three examples.

Thanks in advance


Attachments:
bug.asm [239 Bytes]
Downloaded 79 times

_________________
_________________________________________________________________________
Checkout my 2pass assembler/monitor https://github.com/jdimeglio/6502-Monitor
Top
 Profile  
Reply with quote  
PostPosted: Mon Dec 28, 2020 4:59 pm 
Offline
User avatar

Joined: Fri Aug 30, 2002 9:02 pm
Posts: 1748
Location: Sacramento, CA
Hum, my version 1.3.3.2 does not do that. An earlier version that I still have does do what you describe. Can you verify you have the latest release, which should be 1.3.3.2 as viewed in the "Help - About" screen?

It is also linked here <edit> removed link

Thanks for using the software and please keep reporting any issues you find!!

Daryl

_________________
Please visit my website -> https://sbc.rictor.org/


Last edited by 8BIT on Tue Dec 29, 2020 3:08 am, edited 1 time in total.

Top
 Profile  
Reply with quote  
PostPosted: Tue Dec 29, 2020 12:39 am 
Offline
User avatar

Joined: Wed Nov 11, 2020 3:33 am
Posts: 22
Location: Sydney
Yup first thing ive checked.. The help -About Screen it says 1.3.2 should it say 1.3.3.2 ?

(and that's from the download link you've provided and note the .zip file says 1.3.3.2)

_________________
_________________________________________________________________________
Checkout my 2pass assembler/monitor https://github.com/jdimeglio/6502-Monitor


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 413 posts ]  Go to page Previous  1 ... 6, 7, 8, 9, 10, 11, 12 ... 28  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 7 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to: